postgres.git / summary / log / commit / refs
commit 0125c4e21d7e9c8b3da95ffcd3e34c0f61c9b69a
Author: Masahiko Sawada <msawada@postgresql.org>
Date: Wed Aug 02 06:01:13 2023 +0000
First released in: 17.0, 14.9, 15.4, 16.0
Fix ReorderBufferCheckMemoryLimit() comment.
Commit 7259736a6 updated the comment but it was not correct since
ReorderBufferLargestStreamableTopTXN() returns only top-level
transactions.
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/CAD21AoA9XB7OR86BqvrCe2dMYX%2BZv3-BvVmjF%3DGY2z6jN-kqjg%40mail.gmail.com
Backpatch-through: 14
src/backend/replication/logical/reorderbuffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index 26d252bd875..87a4d2a24b7 100644
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -3602,8 +3602,8 @@ ReorderBufferCheckMemoryLimit(ReorderBuffer *rb)
rb->size > 0))
{
/*
- * Pick the largest transaction (or subtransaction) and evict it from
- * memory by streaming, if possible. Otherwise, spill to disk.
+ * Pick the largest transaction and evict it from memory by streaming,
+ * if possible. Otherwise, spill to disk.
*/
if (ReorderBufferCanStartStreaming(rb) &&
(txn = ReorderBufferLargestStreamableTopTXN(rb)) != NULL)
[parent: 3845577cb55e]