postgres.git / summary / log / commit / refs

commit    013d324d51ef55cbfff50d4302261b5199cd3198
Author:   Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:     Wed Jun 24 18:00:37 2020 +0000
First released in: 14.0, 11.9, 12.4, 13.0

    Add parens to ConvertToXSegs macro
    
    The current definition is dangerous.  No bugs exist in our code at
    present, but backpatch to 11 nonetheless where it was introduced.
    
    Author: Álvaro Herrera <alvherre@alvh.no-ip.org>


 src/backend/access/transam/xlog.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index e285ae96c1e..18b4d11bd03 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -744,9 +744,12 @@ static ControlFileData *ControlFile = NULL;
  */
 #define UsableBytesInPage (XLOG_BLCKSZ - SizeOfXLogShortPHD)
 
-/* Convert min_wal_size_mb and max wal_size_mb to equivalent segment count */
+/*
+ * Convert min_wal_size_mb and max wal_size_mb to equivalent segment count.
+ * Rounds down.
+ */
 #define ConvertToXSegs(x, segsize)	\
-	(x / ((segsize) / (1024 * 1024)))
+	((x) / ((segsize) / (1024 * 1024)))
 
 /* The number of bytes in a WAL segment usable for WAL data. */
 static int	UsableBytesInSegment;


[parent: d3d8755180b6]