postgres.git / summary / log / commit / refs

commit    01f2bc5af4ffa9dbe27bbaf96c73fbfe9e29def4
Author:   Andrew Dunstan <andrew@dunslane.net>
Date:     Mon Apr 25 19:02:13 2022 +0000
First released in: 15.0, 10.21, 11.16, 12.11, 13.7, 14.3

    Inhibit mingw CRT's auto-globbing of command line arguments
    
    For some reason by default the mingw C Runtime takes it upon itself to
    expand program arguments that look like shell globbing characters. That
    has caused much scratching of heads and mis-attribution of the causes of
    some TAP test failures, so stop doing that.
    
    This removes an inconsistency with Windows binaries built with MSVC,
    which have no such behaviour.
    
    Per suggestion from Noah Misch.
    
    Backpatch to all live branches.
    
    Discussion: https://postgr.es/m/20220423025927.GA1274057@rfd.leadboat.com


 src/common/exec.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/common/exec.c b/src/common/exec.c
index 92dc3134a16..ccdb443ea88 100644
--- a/src/common/exec.c
+++ b/src/common/exec.c
@@ -25,6 +25,11 @@
 #include <sys/wait.h>
 #include <unistd.h>
 
+/* Inhibit mingw CRT's auto-globbing of command line arguments */
+#if defined(WIN32) && !defined(_MSC_VER)
+extern int _CRT_glob = 0; /* 0 turns off globbing; 1 turns it on */
+#endif
+
 /*
  * Hacky solution to allow expressing both frontend and backend error reports
  * in one macro call.  First argument of log_error is an errcode() call of


[parent: eade0043caaf]