postgres.git / summary / log / commit / refs

commit    034194470647b3de206fb42464d49a438853fa5e
Author:   Bruce Momjian <bruce@momjian.us>
Date:     Tue Apr 19 23:14:39 2011 +0000
First released in: 9.1.0

    Add C comment
    
    Add C comment about why we throw an error if the pg_upgrade old/new
    database counts don't match.


 contrib/pg_upgrade/relfilenode.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/contrib/pg_upgrade/relfilenode.c b/contrib/pg_upgrade/relfilenode.c
index 9a0a3ac18d9..6fb336cfc53 100644
--- a/contrib/pg_upgrade/relfilenode.c
+++ b/contrib/pg_upgrade/relfilenode.c
@@ -37,6 +37,12 @@ transfer_all_new_dbs(DbInfoArr *old_db_arr,
 
 	prep_status("Restoring user relation files\n");
 
+	/*
+	 *	If the user removed the 'postgres' database from the old cluster,
+	 *	this will cause the database counts to not match and throw an error.
+	 *	We could allow this to work because the new database is empty (we
+	 *	checked), but we don't.
+	 */
 	if (old_db_arr->ndbs != new_db_arr->ndbs)
 		pg_log(PG_FATAL, "old and new clusters have a different number of databases\n");
 


[parent: 8c19977e9c51]