postgres.git / summary / log / commit / refs

commit    055891f374a347aedd53c5b4fc79caf0a5522e18
Author:   Andrew Dunstan <andrew@dunslane.net>
Date:     Fri Jul 12 22:29:15 2024 +0000
First released in: 18.0, 12.20, 13.16, 14.13, 15.8, 16.4, 17.0

    Make sure to run pg_isready on correct port
    
    The current code can have pg_isready unexpectedly succeed if there is a
    server running on the default port. To avoid this we delay running the
    test until after a node has been created but before it starts, and then
    use that node's port, so we are fairly sure there is nothing running on
    the port.
    
    Backpatch to all live branches.


 src/bin/scripts/t/080_pg_isready.pl | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/bin/scripts/t/080_pg_isready.pl b/src/bin/scripts/t/080_pg_isready.pl
index fba3018175f..dd64502e696 100644
--- a/src/bin/scripts/t/080_pg_isready.pl
+++ b/src/bin/scripts/t/080_pg_isready.pl
@@ -12,10 +12,11 @@ program_help_ok('pg_isready');
 program_version_ok('pg_isready');
 program_options_handling_ok('pg_isready');
 
-command_fails(['pg_isready'], 'fails with no server running');
-
 my $node = PostgreSQL::Test::Cluster->new('main');
 $node->init;
+
+$node->command_fails(['pg_isready'], 'fails with no server running');
+
 $node->start;
 
 $node->command_ok(


[parent: a8458f508a7a]