postgres-github.git / summary / log / commit / refs

commit    06a5c3cdef024630aef0992bb7b471459aa2b70f
Author:   Fujii Masao <fujii@postgresql.org>
Date:     Fri May 22 15:25:48 2026 +0000

    Set notice receiver before libpq connection startup completes
    
    Commit 112faf1378e added custom notice receivers for replication,
    postgres_fdw, and dblink so that remote NOTICE, WARNING, and similar
    messages are reported via ereport(). However, those notice receivers were
    installed only after libpqsrv_connect() and libpqsrv_connect_params()
    returned, by which point libpq connection startup had already completed.
    As a result, messages emitted during connection establishment could be
    missed.
    
    This commit fixes the issue by splitting libpqsrv_connect() and
    libpqsrv_connect_params() into separate start and complete phases:
    libpqsrv_connect_start(), libpqsrv_connect_params_start(), and
    libpqsrv_connect_complete(). This allows callers to perform
    per-connection setup, such as installing a notice receiver, after the
    connection has been started but before startup completes.
    
    Note that callers of libpqsrv_connect_start() and
    libpqsrv_connect_params_start() must still call
    libpqsrv_connect_complete(), even if the start function returns NULL, so
    that any external FDs reserved during startup are released properly.
    
    Author: Chao Li <lic@highgo.com>
    Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
    Reviewed-by: Vignesh C <vignesh21@gmail.com>
    Reviewed-by: Rafia Sabih <rafia.pghackers@gmail.com>
    Discussion: https://postgr.es/m/A2B8B7DE-C119-492F-A9FA-14CF86849777@gmail.com

[parent: d8b5d87e545c]