postgres-github.git / summary / log / commit / refs

commit    07009121c235dc1b9338b57b6a85006a5e3b0bd8
Author:   Daniel Gustafsson <dgustafsson@postgresql.org>
Date:     Mon Apr 06 00:03:10 2026 +0000

    Test stabilization for online checksums
    
    Postcommit review and buildfarm/CI failures revealed a few issues in
    the test code which this commit attempts to resolve.  These failures
    are verified using synthetic means.
    
      * Wait for launcher exit in enable/disable checksum tests
    
        When enabling or disabling data checksums in a test with waiting
        for an end state (on or off), the test typically want to perform
        more test against the cluster immediately. Make sure to wait for
        the launcher to exit in these cases before returning in order to
        know it can immediately be acted on.  This is a more generic way
        of implementating 0036232ba8f.
    
      * Refactor injection point tests to use the injection_points test
        extension. Two injection points added for online checksums were
        better expressed using the injection_points extension with the
        test code embedded in datachecksum_state.c.
    
      * Make tests less timing dependent and allow transitions to "on"
        and not just "inprogress-on" in case a test manages to finish
        before it's checked for state.
    
      * When waiting on a blocking background psql keeping a temporary
        table open, the test first closed the background session abd
        then the server.  This could cause data checksums to manage to
        get enabled in the brief window between dropping the temporary
        table and closing the server.  Fix by closing the server first
        before the background session.
    
      * Remove a few superfluous duplicate checks and general cleanup
        of comments as well as making LSN logging consistent.
    
    These issues were reported by Andres as well as spotted in the
    buildfarm and on CI.
    
    Author: Daniel Gustafsson <daniel@yesql.se>
    Reported-by: Andres Freund <andres@anarazel.de>
    Discussion: https://postgr.es/m/92F25C14-801E-4198-994D-D83E31FEB0D8@yesql.se

[parent: d771b0a907e6]