postgres.git / summary / log / commit / refs

commit    074050f16a2db9b5ebe5c9f8fdb211cbb810e746
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Mon Apr 11 04:00:08 2016 +0000

    pg_dump: add missing "destroyPQExpBuffer(query)" in dumpForeignServer().
    
    Coverity complained about this resource leak (why now, I don't know,
    since it's been like that a long time).  Our general policy in pg_dump
    is that PQExpBuffers are worth cleaning up, so do it here too.  But
    don't bother with a back-patch, because it seems unlikely that very
    many databases contain enough FOREIGN SERVER objects to notice.


 src/bin/pg_dump/pg_dump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 6c2167616dd..c999193a238 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -14287,6 +14287,7 @@ dumpForeignServer(Archive *fout, ForeignServerInfo *srvinfo)
 	destroyPQExpBuffer(q);
 	destroyPQExpBuffer(delq);
 	destroyPQExpBuffer(labelq);
+	destroyPQExpBuffer(query);
 }
 
 /*


[parent: 1630f5b92a3a]