pgpool2.git / summary / log / commit / refs

commit    08186df4ee67805230795e7a5da917dffc074e48
Author:   Tatsuo Ishii <ishii@postgresql.org>
Date:     Sat Nov 09 06:29:27 2024 +0000

    Revert "Fix Pgpool-II child process crash during shutdown."
    
    This reverts commit 25ad9e6d50343e2cbd4dc337803d231c92141021.
    
    Per discussion: [pgpool-general: 9265] Re: Segmentation fault during shutdown
    https://www.pgpool.net/pipermail/pgpool-general/2024-November/001942.html


 src/protocol/child.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/protocol/child.c b/src/protocol/child.c
index 4e2a3443b..c12a5a2c1 100644
--- a/src/protocol/child.c
+++ b/src/protocol/child.c
@@ -1350,12 +1350,9 @@ child_will_go_down(int code, Datum arg)
 		memcached_disconnect();
 	}
 
-	/*
-	 * We used to call close_all_backend_connections() here so that we send
-	 * 'X' (terminate) message to backend. However it was possible that the
-	 * function is called while initializing the connection pool object, which
-	 * leads to crash. So we stopped to call close_all_backend_connections().
-	 */
+	/* let backend know now we are exiting */
+	if (pool_connection_pool)
+		close_all_backend_connections();
 }
 
 /*


[parent: 25ad9e6d5034]