postgres.git / summary / log / commit / refs

commit    083031aa99d739f5e8ff26d90e488ed4ac14892e
Author:   Andres Freund <andres@anarazel.de>
Date:     Tue Mar 22 15:22:02 2022 +0000
First released in: 15.0, 10.21, 11.16, 12.11, 13.7, 14.3

    Add missing dependency of pg_dumpall to WIN32RES.
    
    When cross-building to windows, or building with mingw on windows, the build
    could fail with
      x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director
    because pg_dumpall didn't depend on WIN32RES, but it's recipe references
    it. The build nevertheless succeeded most of the time, due to
    pg_dump/pg_restore having the required dependency, causing win32ver.o to be
    built.
    
    Reported-By: Thomas Munro <thomas.munro@gmail.com>
    Discussion: https://postgr.es/m/CA+hUKGJeekpUPWW6yCVdf9=oBAcCp86RrBivo4Y4cwazAzGPng@mail.gmail.com
    Backpatch: 10-, omission present on all live branches


 src/bin/pg_dump/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pg_dump/Makefile b/src/bin/pg_dump/Makefile
index 8c738881cfe..2fe11c49cbf 100644
--- a/src/bin/pg_dump/Makefile
+++ b/src/bin/pg_dump/Makefile
@@ -31,7 +31,7 @@ pg_dump: pg_dump.o common.o pg_dump_sort.o $(OBJS) | submake-libpq submake-libpg
 pg_restore: pg_restore.o $(OBJS) | submake-libpq submake-libpgport submake-libpgfeutils
 	$(CC) $(CFLAGS) pg_restore.o $(OBJS) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X)
 
-pg_dumpall: pg_dumpall.o dumputils.o | submake-libpq submake-libpgport submake-libpgfeutils
+pg_dumpall: pg_dumpall.o dumputils.o $(WIN32RES) | submake-libpq submake-libpgport submake-libpgfeutils
 	$(CC) $(CFLAGS) pg_dumpall.o dumputils.o $(WIN32RES) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X)
 
 install: all installdirs


[parent: 8138bd4a567e]