postgres.git / summary / log / commit / refs

commit    0994cfc0ac853de4245f003698160fe1b8c577bd
Author:   Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:     Fri Jul 26 21:46:40 2019 +0000
First released in: 13.0, 9.6.15, 10.10, 11.5, 12.0

    Don't uselessly escape a string that doesn't need escaping
    
    Per gripe from Ian Barwick
    
    Co-authored-by: Ian Barwick <ian@2ndquadrant.com>
    Discussion: https://postgr.es/m/CABvVfJWNnNKb8cHsTLhkTsvL1+G6BVcV+57+w1JZ61p8YGPdWQ@mail.gmail.com


 src/bin/pg_basebackup/pg_basebackup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
index 77a7c148bae..9207109ba3b 100644
--- a/src/bin/pg_basebackup/pg_basebackup.c
+++ b/src/bin/pg_basebackup/pg_basebackup.c
@@ -1716,9 +1716,9 @@ GenerateRecoveryConf(PGconn *conn)
 
 	if (replication_slot)
 	{
-		escaped = escape_quotes(replication_slot);
-		appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n", replication_slot);
-		free(escaped);
+		/* unescaped: ReplicationSlotValidateName allows [a-z0-9_] only */
+		appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n",
+						  replication_slot);
 	}
 
 	if (PQExpBufferBroken(recoveryconfcontents) ||


[parent: 8ab66081ca49]