postgres.git / summary / log / commit / refs

commit    0bdeb1d51d910e0e19dec3ce0396903ae7de5c74
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Mon Mar 17 01:43:46 2014 +0000
First released in: 9.4.0, 8.4.21, 9.0.17, 9.1.13, 9.2.8, 9.3.4

    Fix advertised dispsize for libpq's sslmode connection parameter.
    
    "8" was correct back when "disable" was the longest allowed value, but
    since "verify-full" was added, it should be "12".  Given the lack of
    complaints, I wouldn't be surprised if nobody is actually using these
    values ... but still, if they're in the API, they should be right.
    
    Noticed while pursuing a different problem.  It's been wrong for quite
    a long time, so back-patch to all supported branches.


src/interfaces/libpq/fe-connect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c index 4de86f28463..10e77d186cf 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -220,7 +220,7 @@ static const PQconninfoOption PQconninfoOptions[] = { * to exclude them since none of them are mandatory. */ {"sslmode", "PGSSLMODE", DefaultSSLMode, NULL, - "SSL-Mode", "", 8}, /* sizeof("disable") == 8 */ + "SSL-Mode", "", 12}, /* sizeof("verify-full") == 12 */ {"sslcompression", "PGSSLCOMPRESSION", "1", NULL, "SSL-Compression", "", 1}, [parent: f2063b379fe1]