postgres.git / summary / log / commit / refs

commit    0be39b4b1a018aa6cea73b0aee4294fb6f57f58d
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Sat Sep 27 18:29:41 2025 +0000

    Fix missed copying of groupDistinct in transformPLAssignStmt.
    
    Because we failed to do this, DISTINCT in GROUP BY DISTINCT would be
    ignored in PL/pgSQL assignment statements.  It's not surprising that
    no one noticed, since such statements will throw an error if the query
    produces more than one row.  That eliminates most scenarios where
    advanced forms of GROUP BY could be useful, and indeed makes it hard
    even to find a simple test case.  Nonetheless it's wrong.
    
    This is directly the fault of be45be9c3 which added the groupDistinct
    field, but I think much of the blame has to fall on c9d529848, in
    which I incautiously supposed that we'd manage to keep two copies of
    a big chunk of parse-analysis logic in sync.  As a follow-up, I plan
    to refactor so that there's only one copy.  But that seems useful
    only in master, so let's use this one-line fix for the back branches.
    
    Author: Tom Lane <tgl@sss.pgh.pa.us>
    Discussion: https://postgr.es/m/31027.1758919078@sss.pgh.pa.us
    Backpatch-through: 14


 src/backend/parser/analyze.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c
index f7ae9230290..fcb79c12fb5 100644
--- a/src/backend/parser/analyze.c
+++ b/src/backend/parser/analyze.c
@@ -2727,6 +2727,7 @@ transformPLAssignStmt(ParseState *pstate, PLAssignStmt *stmt)
 											qry->sortClause,
 											EXPR_KIND_GROUP_BY,
 											false /* allow SQL92 rules */ );
+	qry->groupDistinct = sstmt->groupDistinct;
 
 	if (sstmt->distinctClause == NIL)
 	{


[parent: bc476f8b8b64]