postgres.git / summary / log / commit / refs

commit    0e2c85d130b85549da469e8a16ee1c863e2f3da4
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Tue Mar 07 16:36:35 2017 +0000

    Fix pgbench's failure to honor the documented long-form option "--builtin".
    
    Not only did it not accept --builtin as a synonym for -b, but what it did
    accept as a synonym was --tpc-b (huh?), which it got even further wrong
    by marking as no_argument, so that if you did try that you got a core
    dump.  I suppose this is leftover from some early design for the new
    switches added by commit 8bea3d221, but it's still pretty sloppy work.
    
    Per bug #14580 from Stepan Pesternikov.  Back-patch to 9.6 where the
    error was introduced.
    
    Report: https://postgr.es/m/20170307123347.25054.73207@wrigleys.postgresql.org


 src/bin/pgbench/pgbench.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index 531671a00b4..412f153230c 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -3369,7 +3369,7 @@ main(int argc, char **argv)
 {
 	static struct option long_options[] = {
 		/* systematic long/short named options */
-		{"tpc-b", no_argument, NULL, 'b'},
+		{"builtin", required_argument, NULL, 'b'},
 		{"client", required_argument, NULL, 'c'},
 		{"connect", no_argument, NULL, 'C'},
 		{"debug", no_argument, NULL, 'd'},


[parent: e961341cc149]