postgrespro.git / summary / log / commit / refs

commit    112b006fe79b6fe84647df84a07c201e5a7b1635
Author:   Andres Freund <andres@anarazel.de>
Date:     Tue Mar 24 19:14:18 2020 +0000

    logical decoding: Remove TODO about unnecessary optimization.
    
    Measurements show, and intuition agrees, that there's currently no
    known cases where adding a fastpath to avoid allocating / ordering a
    heap for a single transaction is worthwhile.
    
    Author: Dilip Kumar
    Discussion: https://postgr.es/m/CAFiTN-sp701wvzvnLQJGk7JDqrFM8f--97-ihbwkU8qvn=p8nw@mail.gmail.com


 src/backend/replication/logical/reorderbuffer.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index 481277a1fd..4594cf9509 100644
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -1037,11 +1037,6 @@ ReorderBufferIterTXNInit(ReorderBuffer *rb, ReorderBufferTXN *txn,
 			nr_txns++;
 	}
 
-	/*
-	 * TODO: Consider adding fastpath for the rather common nr_txns=1 case, no
-	 * need to allocate/build a heap then.
-	 */
-
 	/* allocate iteration state */
 	state = (ReorderBufferIterTXNState *)
 		MemoryContextAllocZero(rb->context,


[parent: f15ace793578]