postgrespro.git / summary / log / commit / refs

commit    1171dbde2daef8f0dcd1dc1e54531a0d8dd34d88
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Mon May 13 00:11:50 2019 +0000

    Fix incorrect return value in JSON equality function for scalars
    
    equalsJsonbScalarValue() uses a boolean as return type, however for one
    code path -1 gets returned, which is confusing.  The origin of the
    confusion is visibly that this code got copy-pasted from
    compareJsonbScalarValue() since it has been introduced in d1d50bf.
    
    No backpatch, as this is only cosmetic.
    
    Author: Rikard Falkeborn
    Discussion: https://postgr.es/m/CADRDgG7mJnek6HNW13f+LF6V=6gag9PM+P7H5dnyWZAv49aBGg@mail.gmail.com


 src/backend/utils/adt/jsonb_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/adt/jsonb_util.c b/src/backend/utils/adt/jsonb_util.c
index 3b249fe8cb..1a28d75c59 100644
--- a/src/backend/utils/adt/jsonb_util.c
+++ b/src/backend/utils/adt/jsonb_util.c
@@ -1318,7 +1318,7 @@ equalsJsonbScalarValue(JsonbValue *aScalar, JsonbValue *bScalar)
 		}
 	}
 	elog(ERROR, "jsonb scalar type mismatch");
-	return -1;
+	return false;
 }
 
 /*


[parent: 8a29ed05302e]