postgres.git / summary / log / commit / refs

commit    129a2f6679fd8891384016b6e2cde6cefda22a7d
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Fri Sep 06 15:57:57 2024 +0000
First released in: 18.0, 16.5, 17.0

    Fix incorrect pg_stat_io output on 32-bit machines.
    
    pg_stat_get_io() applied TimestampTzGetDatum twice to the
    stat_reset_timestamp value.  On 64-bit builds that's harmless because
    TimestampTzGetDatum is a no-op, but on 32-bit builds it results in
    displaying garbage in the stats_reset column of the pg_stat_io view.
    
    Bug dates to commit a9c70b46d which introduced pg_stat_io, so
    back-patch to v16 where that came in.
    
    Bertrand Drouvot
    
    Discussion: https://postgr.es/m/Ztrd+XcPTz1zorkg@ip-10-97-1-34.eu-west-3.compute.internal


 src/backend/utils/adt/pgstatfuncs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c
index 97dc09ac0d9..33c7b25560b 100644
--- a/src/backend/utils/adt/pgstatfuncs.c
+++ b/src/backend/utils/adt/pgstatfuncs.c
@@ -1408,7 +1408,7 @@ pg_stat_get_io(PG_FUNCTION_ARGS)
 				values[IO_COL_BACKEND_TYPE] = bktype_desc;
 				values[IO_COL_CONTEXT] = CStringGetTextDatum(context_name);
 				values[IO_COL_OBJECT] = CStringGetTextDatum(obj_name);
-				values[IO_COL_RESET_TIME] = TimestampTzGetDatum(reset_time);
+				values[IO_COL_RESET_TIME] = reset_time;
 
 				/*
 				 * Hard-code this to the value of BLCKSZ for now. Future


[parent: 9e43ab3dd79d]