postgres.git / summary / log / commit / refs

commit    14570c28289f82030172c699ec877dd26d04940a
Author:   Andres Freund <andres@anarazel.de>
Date:     Sun Jan 04 14:35:46 2015 +0000
First released in: 9.5.0

    Remove superflous variable from xlogreader's XLogFindNextRecord().
    
    Pointed out by Coverity.
    
    Since this is mere, and debatable, cosmetics I'm not backpatching
    this.


 src/backend/access/transam/xlogreader.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c
index 67d62234369..db5384c2062 100644
--- a/src/backend/access/transam/xlogreader.c
+++ b/src/backend/access/transam/xlogreader.c
@@ -833,7 +833,6 @@ XLogFindNextRecord(XLogReaderState *state, XLogRecPtr RecPtr)
 	XLogRecPtr	found = InvalidXLogRecPtr;
 	uint32		pageHeaderSize;
 	XLogPageHeader header;
-	XLogRecord *record;
 	int			readLen;
 	char	   *errormsg;
 
@@ -875,7 +874,7 @@ XLogFindNextRecord(XLogReaderState *state, XLogRecPtr RecPtr)
 	 * because either we're at the first record after the beginning of a page
 	 * or we just jumped over the remaining data of a continuation.
 	 */
-	while ((record = XLogReadRecord(state, tmpRecPtr, &errormsg)))
+	while (XLogReadRecord(state, tmpRecPtr, &errormsg) != NULL)
 	{
 		/* continue after the record */
 		tmpRecPtr = InvalidXLogRecPtr;


[parent: 58bc4747be26]