postgres.git / summary / log / commit / refs

commit    151e463c91e0a83a5d277dccae43a7724ffe1e76
Author:   Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:     Thu Mar 17 15:49:38 2011 +0000

    Fix PL/Python memory leak involving array slices
    
    Report and patch from Daniel Popowich, bug #5842
    (with some debugging help from Alex Hunsaker)


 src/pl/plpython/plpython.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
index edcbc2a7ed8..f89071ec734 100644
--- a/src/pl/plpython/plpython.c
+++ b/src/pl/plpython/plpython.c
@@ -2261,14 +2261,9 @@ PLy_result_ass_item(PyObject * arg, Py_ssize_t idx, PyObject * item)
 static PyObject *
 PLy_result_slice(PyObject * arg, Py_ssize_t lidx, Py_ssize_t hidx)
 {
-	PyObject   *rv;
 	PLyResultObject *ob = (PLyResultObject *) arg;
 
-	rv = PyList_GetSlice(ob->rows, lidx, hidx);
-	if (rv == NULL)
-		return NULL;
-	Py_INCREF(rv);
-	return rv;
+	return PyList_GetSlice(ob->rows, lidx, hidx);
 }
 
 static int


[parent: 5773fac1606c]