postgres.git / summary / log / commit / refs

commit    162e70ea06eb31dfe8f75bf508afde323eb0b077
Author:   Álvaro Herrera <alvherre@kurilemu.de>
Date:     Sat Oct 18 15:50:10 2025 +0000
First released in: 13.23, 14.20, 15.15, 16.11, 17.7, 18.1

    Fix pg_dump sorting of foreign key constraints
    
    Apparently, commit 04bc2c42f765 failed to notice that DO_FK_CONSTRAINT
    objects require identical handling as DO_CONSTRAINT ones, which causes
    some pg_upgrade tests in debug builds to fail spuriously.  Add that.
    
    Author: Álvaro Herrera <alvherre@kurilemu.de>
    Backpatch-through: 13
    Discussion: https://postgr.es/m/202510181201.k6y75v2tpf5r@alvherre.pgsql


 src/bin/pg_dump/pg_dump_sort.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/bin/pg_dump/pg_dump_sort.c b/src/bin/pg_dump/pg_dump_sort.c
index 61a0f69ff3a..edd7139ebfe 100644
--- a/src/bin/pg_dump/pg_dump_sort.c
+++ b/src/bin/pg_dump/pg_dump_sort.c
@@ -385,7 +385,8 @@ DOTypeNameCompare(const void *p1, const void *p2)
 		if (cmpval != 0)
 			return cmpval;
 	}
-	else if (obj1->objType == DO_CONSTRAINT)
+	else if (obj1->objType == DO_CONSTRAINT ||
+			 obj1->objType == DO_FK_CONSTRAINT)
 	{
 		ConstraintInfo *robj1 = *(ConstraintInfo *const *) p1;
 		ConstraintInfo *robj2 = *(ConstraintInfo *const *) p2;


[parent: 0b6a02f0355c]