postgres.git / summary / log / commit / refs

commit    171198ff2a57fafe0772ec9d3dfbf061cffffacd
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Mon Dec 15 01:28:28 2025 +0000

    pageinspect: use index_close() for GiST index relation
    
    gist_page_items() opens its target relation with index_open(), but
    closed it using relation_close() instead of index_close().  This was
    harmless because index_close() and relation_close() do the exact same
    work, still inconsistent with the rest of the code tree as routines
    opening and closing a relation based on a relkind are expected to match,
    at least in name.
    
    Author: Chao Li <li.evan.chao@gmail.com>
    Discussion: https://postgr.es/m/CAEoWx2=bL41WWcD-4Fxx-buS2Y2G5=9PjkxZbHeFMR6Uy2WNvw@mail.gmail.com


 contrib/pageinspect/gistfuncs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/pageinspect/gistfuncs.c b/contrib/pageinspect/gistfuncs.c
index de3746a156b..414513c395b 100644
--- a/contrib/pageinspect/gistfuncs.c
+++ b/contrib/pageinspect/gistfuncs.c
@@ -361,7 +361,7 @@ gist_page_items(PG_FUNCTION_ARGS)
 		tuplestore_putvalues(rsinfo->setResult, rsinfo->setDesc, values, nulls);
 	}
 
-	relation_close(indexRel, AccessShareLock);
+	index_close(indexRel, AccessShareLock);
 
 	return (Datum) 0;
 }


[parent: 481783e69f14]