postgres.git / summary / log / commit / refs

commit    1988f8766eeb297d7867e92bcfdea2e4ff894cc7
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Thu Sep 14 07:00:41 2023 +0000

    Revert "Improve error message on snapshot import in snapmgr.c"
    
    This reverts commit a0d87bcd9b57, following a remark from Andres Frend
    that the new error can be triggered with an incorrect SET TRANSACTION
    SNAPSHOT command without being really helpful for the user as it uses
    the internal file name.
    
    Discussion: https://postgr.es/m/20230914020724.hlks7vunitvtbbz4@awork3.anarazel.de
    Backpatch-through: 11


 src/backend/utils/time/snapmgr.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
index dbba2f7d7b2..3037cf478d1 100644
--- a/src/backend/utils/time/snapmgr.c
+++ b/src/backend/utils/time/snapmgr.c
@@ -1443,9 +1443,8 @@ ImportSnapshot(const char *idstr)
 	f = AllocateFile(path, PG_BINARY_R);
 	if (!f)
 		ereport(ERROR,
-				(errcode_for_file_access(),
-				 errmsg("could not open file \"%s\" for reading: %m",
-						path)));
+				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+				 errmsg("invalid snapshot identifier: \"%s\"", idstr)));
 
 	/* get the size of the file so that we know how much memory we need */
 	if (fstat(fileno(f), &stat_buf))


[parent: a7b92d1c6807]