postgres.git / summary / log / commit / refs

commit    1b2356a2911ca84eefdf5dcb7f574677b8879c80
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Thu Dec 26 13:26:31 2019 +0000
First released in: 13.0, 11.7, 12.2

    Fix some comments related to logical repslot advancing
    
    confirmed_flush is part of a replication slot's information, but not
    confirmed_lsn.
    
    Author: Kyotaro Horiguchi
    Discussion: https://postgr.es/m/20191226.175919.17237335658671970.horikyota.ntt@gmail.com
    Backpatch-through: 11


 src/backend/replication/slotfuncs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/replication/slotfuncs.c b/src/backend/replication/slotfuncs.c
index 9c8c86f12b7..9bfeca20557 100644
--- a/src/backend/replication/slotfuncs.c
+++ b/src/backend/replication/slotfuncs.c
@@ -343,8 +343,8 @@ pg_physical_replication_slot_advance(XLogRecPtr moveto)
 /*
  * Helper function for advancing our logical replication slot forward.
  *
- * The slot's restart_lsn is used as start point for reading records,
- * while confirmed_lsn is used as base point for the decoding context.
+ * The slot's restart_lsn is used as start point for reading records, while
+ * confirmed_flush is used as base point for the decoding context.
  *
  * We cannot just do LogicalConfirmReceivedLocation to update confirmed_flush,
  * because we need to digest WAL to advance restart_lsn allowing to recycle
@@ -514,8 +514,8 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS)
 	/*
 	 * Check if the slot is not moving backwards.  Physical slots rely simply
 	 * on restart_lsn as a minimum point, while logical slots have confirmed
-	 * consumption up to confirmed_lsn, meaning that in both cases data older
-	 * than that is not available anymore.
+	 * consumption up to confirmed_flush, meaning that in both cases data
+	 * older than that is not available anymore.
 	 */
 	if (OidIsValid(MyReplicationSlot->data.database))
 		minlsn = MyReplicationSlot->data.confirmed_flush;


[parent: 9e551a14cb45]