postgres.git / summary / log / commit / refs
commit 1db7119ac652f1f4bcba0c4b7a3d2fb4a5fa9f60
Author: Masahiko Sawada <msawada@postgresql.org>
Date: Wed Nov 11 18:38:21 2026 +0000
First released in: 19.0
Fix the type of heap tuple count passed to parallel vacuum.
Commit 8e1fae19386 declared the heap tuple count passed to parallel
index bulk-deletion and cleanup as long, although the callers pass a
double and it's stored as a double for the index AMs. On platforms
where long is 32 bits, such as Windows, a count above LONG_MAX doesn't
fit, so the index AMs could get a bogus num_heap_tuples when vacuuming
in parallel. In the cleanup phase, this could lead to wrong index
statistics.
Fix by declaring it as double.
The bug exists since v15, but changing the function signatures would
break ABI in released branches, so backpatch to v19 only.
Author: Baji Shaik <baji.pgdev@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/CA+fm-ROT7pH2oBrp=hOJfh8ux+UO0Y0vRk7xD_wcdRVVqWrs+g@mail.gmail.com
Backpatch-through: 19
src/backend/commands/vacuumparallel.c | 4 ++--
src/include/commands/vacuum.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/vacuumparallel.c b/src/backend/commands/vacuumparallel.c
index fbbd4f5a622..643a380adcc 100644
--- a/src/backend/commands/vacuumparallel.c
+++ b/src/backend/commands/vacuumparallel.c
@@ -599,7 +599,7 @@ parallel_vacuum_reset_dead_items(ParallelVacuumState *pvs)
* Do parallel index bulk-deletion with parallel workers.
*/
void
-parallel_vacuum_bulkdel_all_indexes(ParallelVacuumState *pvs, long num_table_tuples,
+parallel_vacuum_bulkdel_all_indexes(ParallelVacuumState *pvs, double num_table_tuples,
int num_index_scans, PVWorkerStats *wstats)
{
Assert(!IsParallelWorker());
@@ -618,7 +618,7 @@ parallel_vacuum_bulkdel_all_indexes(ParallelVacuumState *pvs, long num_table_tup
* Do parallel index cleanup with parallel workers.
*/
void
-parallel_vacuum_cleanup_all_indexes(ParallelVacuumState *pvs, long num_table_tuples,
+parallel_vacuum_cleanup_all_indexes(ParallelVacuumState *pvs, double num_table_tuples,
int num_index_scans, bool estimated_count,
PVWorkerStats *wstats)
{
diff --git a/src/include/commands/vacuum.h b/src/include/commands/vacuum.h
index 30f4c7c7568..396020e6cde 100644
--- a/src/include/commands/vacuum.h
+++ b/src/include/commands/vacuum.h
@@ -414,11 +414,11 @@ extern TidStore *parallel_vacuum_get_dead_items(ParallelVacuumState *pvs,
VacDeadItemsInfo **dead_items_info_p);
extern void parallel_vacuum_reset_dead_items(ParallelVacuumState *pvs);
extern void parallel_vacuum_bulkdel_all_indexes(ParallelVacuumState *pvs,
- long num_table_tuples,
+ double num_table_tuples,
int num_index_scans,
PVWorkerStats *wstats);
extern void parallel_vacuum_cleanup_all_indexes(ParallelVacuumState *pvs,
- long num_table_tuples,
+ double num_table_tuples,
int num_index_scans,
bool estimated_count,
PVWorkerStats *wstats);
[parent: c0a8bb126292]