postgres.git / summary / log / commit / refs

commit    1ea44d7ddfb6ebacb6fb8ae2f5d6e904b2394f29
Author:   Fujii Masao <fujii@postgresql.org>
Date:     Tue Jan 27 02:55:32 2026 +0000

    Remove unnecessary abort() from WalSndShutdown().
    
    WalSndShutdown() previously called abort() after proc_exit(0) to
    silence compiler warnings. This is no longer needed, because both
    WalSndShutdown() and proc_exit() are declared pg_noreturn,
    allowing the compiler to recognize that the function does not return.
    Also there are already other functions, such as CheckpointerMain(),
    that call proc_exit() without an abort(), and they do not produce warnings.
    
    Therefore this abort() call in WalSndShutdown() is useless and
    this commit removes it.
    
    Author: Fujii Masao <masao.fujii@gmail.com>
    Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
    Discussion: https://postgr.es/m/CAHGQGwHPX1yoixq+YB5rF4zL90TMmSEa3FpHURtqW3Jc5+=oSA@mail.gmail.com


 src/backend/replication/walsender.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
index 1ab09655a70..a0e6a3d200c 100644
--- a/src/backend/replication/walsender.c
+++ b/src/backend/replication/walsender.c
@@ -391,7 +391,6 @@ WalSndShutdown(void)
 		whereToSendOutput = DestNone;
 
 	proc_exit(0);
-	abort();					/* keep the compiler quiet */
 }
 
 /*


[parent: 09c37015d496]