pgbackrest.git / summary / log / commit / refs

commit    1fd8845c7ffd76ee335ec7960ccd531eef43bd29
Author:   David Steele <david@pgmasters.net>
Date:     Thu Jun 29 09:08:58 2023 +0000

    Remove unresolved todo from 87087fac.
    
    Seems easiest just to make the additional config required since it tests that custom ports are being used correctly. The test for synthetic was a noop since SFTP is not used in synthetic tests.


 test/lib/pgBackRestTest/Env/Host/HostBackupTest.pm | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/test/lib/pgBackRestTest/Env/Host/HostBackupTest.pm b/test/lib/pgBackRestTest/Env/Host/HostBackupTest.pm
index c1bef5f75..3bca14a48 100644
--- a/test/lib/pgBackRestTest/Env/Host/HostBackupTest.pm
+++ b/test/lib/pgBackRestTest/Env/Host/HostBackupTest.pm
@@ -1288,14 +1288,7 @@ sub configCreate
         $oParamHash{$strStanza}{"pg256-host-cmd"} = $oHostDb2->backrestExe();
         $oParamHash{$strStanza}{"pg256-host-config"} = $oHostDb2->backrestConfig();
         $oParamHash{$strStanza}{"pg256-path"} = $oHostDb2->dbBasePath();
-
-
-        # !!! is this needed???
-        # Only test explicit ports on the backup server. This is so locally configured ports are also tested.
-        if (!$self->synthetic())
-        {
-            $oParamHash{$strStanza}{"pg256-port"} = $oHostDb2->pgPort();
-        }
+        $oParamHash{$strStanza}{"pg256-port"} = $oHostDb2->pgPort();
     }
 
     # If this is a database host


[parent: 0051d7ca872c]