postgres.git / summary / log / commit / refs

commit    232e0f5de41b904daa111dbd274c2cb2028991a4
Author:   David Rowley <drowley@postgresql.org>
Date:     Mon Nov 24 04:01:13 2025 +0000
First released in: 14.21, 15.16, 16.12, 17.8, 18.2

    Fix incorrect IndexOptInfo header comment
    
    The comment incorrectly indicated that indexcollations[] stored
    collations for both key columns and INCLUDE columns, but in reality it
    only has elements for the key columns.  canreturn[] didn't get a mention,
    so add that while we're here.
    
    Author: Junwang Zhao <zhjwpku@gmail.com>
    Reviewed-by: David Rowley <dgrowleyml@gmail.com>
    Discussion: https://postgr.es/m/CAEG8a3LwbZgMKOQ9CmZarX5DEipKivdHp5PZMOO-riL0w%3DL%3D4A%40mail.gmail.com
    Backpatch-through: 14


 src/include/nodes/pathnodes.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/include/nodes/pathnodes.h b/src/include/nodes/pathnodes.h
index 576f1c7e9b9..a0b73268bbe 100644
--- a/src/include/nodes/pathnodes.h
+++ b/src/include/nodes/pathnodes.h
@@ -1069,9 +1069,10 @@ typedef struct RelOptInfo
  * IndexOptInfo
  *		Per-index information for planning/optimization
  *
- *		indexkeys[], indexcollations[] each have ncolumns entries.
- *		opfamily[], and opcintype[]	each have nkeycolumns entries. They do
- *		not contain any information about included attributes.
+ *		indexkeys[] and canreturn[] each have ncolumns entries.
+ *
+ *		indexcollations[], opfamily[], and opcintype[] each have nkeycolumns
+ *		entries.  These don't contain any information about INCLUDE columns.
  *
  *		sortopfamily[], reverse_sort[], and nulls_first[] have
  *		nkeycolumns entries, if the index is ordered; but if it is unordered,


[parent: 60215eae7c42]