postgres.git / summary / log / commit / refs

commit    23524418e578085cb37bfb064ddd4bc1172c069e
Author:   Bruce Momjian <bruce@momjian.us>
Date:     Fri Nov 02 13:11:00 2018 +0000
First released in: 12.0, 9.3.25, 9.4.20, 9.5.15, 9.6.11, 10.6, 11.1

    GUC:  adjust effective_cache_size docs and SQL description
    
    Clarify that effective_cache_size is both kernel buffers and shared
    buffers.
    
    Reported-by: nat@makarevitch.org
    
    Discussion: https://postgr.es/m/153685164808.22334.15432535018443165207@wrigleys.postgresql.org
    
    Backpatch-through: 9.3


doc/src/sgml/config.sgml | 3 ++- src/backend/utils/misc/guc.c | 7 +++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 457029b0d4f..347abbe4c9b 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -4143,7 +4143,8 @@ ANY <replaceable class="parameter">num_sync</replaceable> ( <replaceable class=" used. When setting this parameter you should consider both <productname>PostgreSQL</productname>'s shared buffers and the portion of the kernel's disk cache that will be used for - <productname>PostgreSQL</productname> data files. Also, take + <productname>PostgreSQL</productname> data files, though some + data might exist in both places. Also, take into account the expected number of concurrent queries on different tables, since they will have to share the available space. This parameter has no effect on the size of shared diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 110ac0e57fb..cb0d1c54f68 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -2979,10 +2979,9 @@ static struct config_int ConfigureNamesInt[] = { {"effective_cache_size", PGC_USERSET, QUERY_TUNING_COST, - gettext_noop("Sets the planner's assumption about the size of the disk cache."), - gettext_noop("That is, the portion of the kernel's disk cache that " - "will be used for PostgreSQL data files. This is measured in disk " - "pages, which are normally 8 kB each."), + gettext_noop("Sets the planner's assumption about the size of the data cache."), + gettext_noop("That is, the size of the cache used for PostgreSQL data files. " + "This is measured in disk pages, which are normally 8 kB each."), GUC_UNIT_BLOCKS, }, &effective_cache_size, [parent: 708b96d56aee]