postgres.git / summary / log / commit / refs

commit    27dbe1a18423f2f80c10d191844a0ba4dea650ff
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Tue Apr 21 22:27:03 2020 +0000
First released in: 13.0, 9.5.22, 9.6.18, 10.13, 11.8, 12.3

    Fix memory leak in libpq when using sslmode=verify-full
    
    Checking if Subject Alternative Names (SANs) from a certificate match
    with the hostname connected to leaked memory after each lookup done.
    
    This is broken since acd08d7 that added support for SANs in SSL
    certificates, so backpatch down to 9.5.
    
    Author: Roman Peshkurov
    Reviewed-by: Hamid Akhtar, Michael Paquier, David Steele
    Discussion: https://postgr.es/m/CALLDf-pZ-E3mjxd5=bnHsDu9zHEOnpgPgdnO84E2RuwMCjjyPw@mail.gmail.com
    Backpatch-through: 9.5


 src/interfaces/libpq/fe-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/interfaces/libpq/fe-secure-openssl.c b/src/interfaces/libpq/fe-secure-openssl.c
index d3a37e1d273..731aa23c553 100644
--- a/src/interfaces/libpq/fe-secure-openssl.c
+++ b/src/interfaces/libpq/fe-secure-openssl.c
@@ -552,7 +552,7 @@ pgtls_verify_peer_name_matches_certificate_guts(PGconn *conn,
 			if (rc != 0)
 				break;
 		}
-		sk_GENERAL_NAME_free(peer_san);
+		sk_GENERAL_NAME_pop_free(peer_san, GENERAL_NAME_free);
 	}
 
 	/*


[parent: 8803506c411e]