postgres.git / summary / log / commit / refs

commit    27f7f81e4c8d5d390ea212d13b65ada8e4a232cd
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Tue Dec 19 23:39:54 2023 +0000
First released in: 17.0

    basic_archive: Fix comments related to NO_INSTALLCHECK
    
    These comments incorrectly referred to shared_preload_libraries as being
    required for the test to work.
    
    Thinko in commit c68a1839902d.
    
    Author: Bharath Rupireddy
    Discussion: https://postgr.es/m/CALj2ACXpjFDiXf-L7AARQ4ppuxiDYSKZjyZb=wOa+cgg0zuWAw@mail.gmail.com


 contrib/basic_archive/Makefile    | 5 +++--
 contrib/basic_archive/meson.build | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/contrib/basic_archive/Makefile b/contrib/basic_archive/Makefile
index 55d299d650c..100ed81f12a 100644
--- a/contrib/basic_archive/Makefile
+++ b/contrib/basic_archive/Makefile
@@ -5,8 +5,9 @@ PGFILEDESC = "basic_archive - basic archive module"
 
 REGRESS = basic_archive
 REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/basic_archive/basic_archive.conf
-# Disabled because these tests require "shared_preload_libraries=basic_archive",
-# which typical installcheck users do not have (e.g. buildfarm clients).
+
+# Disabled because these tests require special configuration, which
+# typical installcheck users do not have (e.g. buildfarm clients).
 NO_INSTALLCHECK = 1
 
 ifdef USE_PGXS
diff --git a/contrib/basic_archive/meson.build b/contrib/basic_archive/meson.build
index bc1380e6f66..e7f22a8f379 100644
--- a/contrib/basic_archive/meson.build
+++ b/contrib/basic_archive/meson.build
@@ -27,8 +27,8 @@ tests += {
     'regress_args': [
       '--temp-config', files('basic_archive.conf'),
     ],
-    # Disabled because these tests require "shared_preload_libraries=basic_archive",
-    # which typical runningcheck users do not have (e.g. buildfarm clients).
+    # Disabled because these tests require special configuration, which
+    # typical installcheck users do not have (e.g. buildfarm clients).
     'runningcheck': false,
   },
 }


[parent: aafc07c7a191]