postgres.git / summary / log / commit / refs

commit    28d27cfdc9f5b18b8695429601bf2440fec17142
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Mon Aug 16 17:33:30 2010 +0000
First released in: 9.1.0, 7.4.30, 8.0.26, 8.1.22, 8.2.18, 8.3.12, 8.4.5, 9.0.0

    Arrange to fsync the contents of lockfiles (both postmaster.pid and the
    socket lockfile) when writing them.  The lack of an fsync here may well
    explain two different reports we've seen of corrupted lockfile contents,
    which doesn't particularly bother the running server but can prevent a
    new server from starting if the old one crashes.  Per suggestion from
    Alvaro.
    
    Back-patch to all supported versions.


 src/backend/utils/init/miscinit.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c
index 614f0a205fd..3f2212d3745 100644
--- a/src/backend/utils/init/miscinit.c
+++ b/src/backend/utils/init/miscinit.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/init/miscinit.c,v 1.116.2.2 2009/12/09 21:59:07 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/init/miscinit.c,v 1.116.2.3 2010/08/16 17:33:30 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -721,6 +721,7 @@ CreateLockFile(const char *filename, bool amPostmaster,
 				(errcode_for_file_access(),
 			  errmsg("could not write lock file \"%s\": %m", filename)));
 	}
+	pg_fsync(fd);
 	close(fd);
 
 	/*
@@ -875,6 +876,7 @@ RecordSharedMemoryInLockFile(unsigned long id1, unsigned long id2)
 		close(fd);
 		return;
 	}
+	pg_fsync(fd);
 	close(fd);
 }
 


[parent: 9217dee11811]