postgres.git / summary / log / commit / refs

commit    2aca19f2989aa938ece7306678f5494a984ece3f
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Mon Jul 05 23:10:59 2021 +0000
First released in: 15.0

    Use WaitLatch() instead of pg_usleep() at the end of backups
    
    This concerns pg_stop_backup() and BASE_BACKUP, when waiting for the
    WAL segments required for a backup to be archived.  This simplifies a
    bit the handling of the wait event used in this code path.
    
    Author: Bharath Rupireddy
    Reviewed-by: Michael Paquier, Stephen Frost
    Discussion: https://postgr.es/m/CALj2ACU4AdPCq6NLfcA-ZGwX7pPCK5FgEj-CAU0xCKzkASSy_A@mail.gmail.com


 src/backend/access/transam/xlog.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 7890e13d7a1..c7c928f50bd 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -11638,9 +11638,11 @@ do_pg_stop_backup(char *labelfile, bool waitforarchive, TimeLineID *stoptli_p)
 				reported_waiting = true;
 			}
 
-			pgstat_report_wait_start(WAIT_EVENT_BACKUP_WAIT_WAL_ARCHIVE);
-			pg_usleep(1000000L);
-			pgstat_report_wait_end();
+			(void) WaitLatch(MyLatch,
+							 WL_LATCH_SET | WL_TIMEOUT | WL_EXIT_ON_PM_DEATH,
+							 1000L,
+							 WAIT_EVENT_BACKUP_WAIT_WAL_ARCHIVE);
+			ResetLatch(MyLatch);
 
 			if (++waits >= seconds_before_warning)
 			{


[parent: 9753324b7d9e]