postgres.git / summary / log / commit / refs

commit    2bb87a61a84ab74b7ba820aac787443a78897bf4
Author:   Bruce Momjian <bruce@momjian.us>
Date:     Tue Feb 01 17:22:34 2011 +0000
First released in: 9.1.0

    Add pg_upgrade comment for why we can't use template1 inheritance for
    the support functions.


 contrib/pg_upgrade/pg_upgrade.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/contrib/pg_upgrade/pg_upgrade.c b/contrib/pg_upgrade/pg_upgrade.c
index d3e1fefa40a..368c0e781a6 100644
--- a/contrib/pg_upgrade/pg_upgrade.c
+++ b/contrib/pg_upgrade/pg_upgrade.c
@@ -236,7 +236,9 @@ prepare_new_databases(void)
 
 	/*
 	 * We have to create the databases first so we can install support
-	 * functions in all the other databases.
+	 * functions in all the other databases.  Ideally we could create
+	 * the support functions in template1 but pg_dumpall creates database
+	 * using the template0 template.
 	 */
 	exec_prog(true,
 			  SYSTEMQUOTE "\"%s/psql\" --set ON_ERROR_STOP=on "


[parent: ef19dc6d39dd]