postgres.git / summary / log / commit / refs

commit    2e9650cbcff8c8fb0d9ef807c73a44f241822eee
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Thu Jan 08 13:42:33 2009 +0000
First released in: 8.4.0
Reverted by: d47fff3d72cd (in 9.2.10), c2b4ed19f6b6 (in 9.3.6), 40b85a3ab11e (in 9.4.0), 677708032c4a (in 9.5.0)

    Defend against null input in analyze_requires_snapshot(), per report
    from Rushabh Lathia.


 src/backend/parser/analyze.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c
index 9c896b07f68..6b54e9ba173 100644
--- a/src/backend/parser/analyze.c
+++ b/src/backend/parser/analyze.c
@@ -17,7 +17,7 @@
  * Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	$PostgreSQL: pgsql/src/backend/parser/analyze.c,v 1.386 2009/01/01 17:23:45 momjian Exp $
+ *	$PostgreSQL: pgsql/src/backend/parser/analyze.c,v 1.387 2009/01/08 13:42:33 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -222,13 +222,17 @@ transformStmt(ParseState *pstate, Node *parseTree)
  *		Returns true if a snapshot must be set before doing parse analysis
  *		on the given raw parse tree.
  *
- * Classification here should match transformStmt().
+ * Classification here should match transformStmt(); but we also have to
+ * allow a NULL input (for Parse/Bind of an empty query string).
  */
 bool
 analyze_requires_snapshot(Node *parseTree)
 {
 	bool		result;
 
+	if (parseTree == NULL)
+		return false;
+
 	switch (nodeTag(parseTree))
 	{
 			/*


[parent: 3467f029571b]