postgres.git / summary / log / commit / refs

commit    30776ca46865f9e04ff6eb5cfdd64eb8bf5c4ff1
Author:   Alexander Korotkov <akorotkov@postgresql.org>
Date:     Tue Jan 20 14:10:25 2026 +0000

    Remove redundant pg_unreachable() after elog(ERROR) from ExecWaitStmt()
    
    elog(ERROR) never returns.  Compilers don't always understand this.  So,
    sometimes, we have to append pg_unreachable() to keep the compiler quiet
    about returning from a non-void function without a value.  But
    pg_unreachable() is redundant for ExecWaitStmt(), which is void.
    
    Reported-by: Peter Eisentraut <peter@eisentraut.org>
    Author: Xuneng Zhou <xunengzhou@gmail.com>
    Discussion: https://postgr.es/m/8d72a2b3-7423-4a15-a981-e130bf60b1a6%40eisentraut.org
    Discussion: https://postgr.es/m/CABPTF7UcuVD0L-X%3DjZFfeygjPaZWWkVRwtWOaJw2tcXbEN2xsA%40mail.gmail.com


 src/backend/commands/wait.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/backend/commands/wait.c b/src/backend/commands/wait.c
index 97f1e778488..1290df10c6f 100644
--- a/src/backend/commands/wait.c
+++ b/src/backend/commands/wait.c
@@ -236,7 +236,6 @@ ExecWaitStmt(ParseState *pstate, WaitStmt *stmt, DestReceiver *dest)
 
 					default:
 						elog(ERROR, "unexpected wait LSN type %d", lsnType);
-						pg_unreachable();
 				}
 			}
 			else
@@ -281,7 +280,6 @@ ExecWaitStmt(ParseState *pstate, WaitStmt *stmt, DestReceiver *dest)
 
 						default:
 							elog(ERROR, "unexpected wait LSN type %d", lsnType);
-							pg_unreachable();
 					}
 				}
 				else
@@ -311,7 +309,6 @@ ExecWaitStmt(ParseState *pstate, WaitStmt *stmt, DestReceiver *dest)
 
 						default:
 							elog(ERROR, "unexpected wait LSN type %d", lsnType);
-							pg_unreachable();
 					}
 				}
 			}


[parent: 1ba3eee89a75]