postgres.git / summary / log / commit / refs

commit    32b32845e05c4dfe0862c89d12e0cacef4e018bb
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Fri Nov 15 23:34:14 2013 +0000
First released in: 9.4.0, 8.4.19, 9.0.15, 9.1.11, 9.2.6, 9.3.2

    Fix incorrect loop counts in tidbitmap.c.
    
    A couple of places that should have been iterating over WORDS_PER_CHUNK
    words were iterating over WORDS_PER_PAGE words instead.  This thinko
    accidentally failed to fail, because (at least on common architectures
    with default BLCKSZ) WORDS_PER_CHUNK is a bit less than WORDS_PER_PAGE,
    and the extra words being looked at were always zero so nothing happened.
    Still, it's a bug waiting to happen if anybody ever fools with the
    parameters affecting TIDBitmap sizes, and it's a small waste of cycles
    too.  So back-patch to all active branches.
    
    Etsuro Fujita


src/backend/nodes/tidbitmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/nodes/tidbitmap.c b/src/backend/nodes/tidbitmap.c index 54d8028da01..123e9c37e14 100644 --- a/src/backend/nodes/tidbitmap.c +++ b/src/backend/nodes/tidbitmap.c @@ -362,7 +362,7 @@ tbm_union_page(TIDBitmap *a, const PagetableEntry *bpage) if (bpage->ischunk) { /* Scan b's chunk, mark each indicated page lossy in a */ - for (wordnum = 0; wordnum < WORDS_PER_PAGE; wordnum++) + for (wordnum = 0; wordnum < WORDS_PER_CHUNK; wordnum++) { bitmapword w = bpage->words[wordnum]; @@ -474,7 +474,7 @@ tbm_intersect_page(TIDBitmap *a, PagetableEntry *apage, const TIDBitmap *b) /* Scan each bit in chunk, try to clear */ bool candelete = true; - for (wordnum = 0; wordnum < WORDS_PER_PAGE; wordnum++) + for (wordnum = 0; wordnum < WORDS_PER_CHUNK; wordnum++) { bitmapword w = apage->words[wordnum]; [parent: 1821ef15bd06]