postgres.git / summary / log / commit / refs
commit 33bfbef1d60fdccbfb72423b2e1e7c4074a640b9
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Wed Mar 20 14:28:14 2024 +0000
Review wording on tablespaces w.r.t. partitioned tables
Remove a redundant comment, and document pg_class.reltablespace properly
in catalogs.sgml.
After commits a36c84c3e4a9, 87259588d0ab and others.
Backpatch to 12.
Discussion: https://postgr.es/m/202403191013.w2kr7wqlamqz@alvherre.pgsql
doc/src/sgml/catalogs.sgml | 9 ++++++---
src/backend/commands/tablecmds.c | 4 ----
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index 7be2d317295..9052981d300 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -1970,9 +1970,12 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l
(references <link linkend="catalog-pg-tablespace"><structname>pg_tablespace</structname></link>.<structfield>oid</structfield>)
</para>
<para>
- The tablespace in which this relation is stored. If zero,
- the database's default tablespace is implied. (Not meaningful
- if the relation has no on-disk file.)
+ The tablespace in which this relation is stored.
+ If zero, the database's default tablespace is implied.
+ Not meaningful if the relation has no on-disk file,
+ except for partitioned tables, where this is the tablespace
+ in which partitions will be created when one is not
+ specified in the creation command.
</para></entry>
</row>
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 1dff4c3529b..b55eec11579 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -755,10 +755,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
}
else if (stmt->partbound)
{
- /*
- * For partitions, when no other tablespace is specified, we default
- * the tablespace to the parent partitioned table's.
- */
Assert(list_length(inheritOids) == 1);
tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));
}
[parent: 262757b73286]