postgres.git / summary / log / commit / refs

commit    33d3fc5e2aac32fcf356c09cee4bfded6613a1f3
Author:   Noah Misch <noah@leadboat.com>
Date:     Thu Apr 07 03:40:51 2016 +0000

    Remove redundant message in AddUserToTokenDacl().
    
    GetTokenUser() will have reported an adequate error message.  These
    error conditions almost can't happen, so users are unlikely to observe
    this change.
    
    Reviewed by Tom Lane and Stephen Frost.


 src/common/exec.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/common/exec.c b/src/common/exec.c
index ec8c6556365..d736b02280d 100644
--- a/src/common/exec.c
+++ b/src/common/exec.c
@@ -674,10 +674,7 @@ AddUserToTokenDacl(HANDLE hToken)
 
 	/* Get the current user SID */
 	if (!GetTokenUser(hToken, &pTokenUser))
-	{
-		log_error("could not get token user: error code %lu", GetLastError());
-		goto cleanup;
-	}
+		goto cleanup;			/* callee printed a message */
 
 	/* Figure out the size of the new ACL */
 	dwNewAclSize = asi.AclBytesInUse + sizeof(ACCESS_ALLOWED_ACE) +


[parent: 29dd1504a12f]