postgres.git / summary / log / commit / refs

commit    34fbfe1f57d84163fea4e234bf78d3b5fd5364b1
Author:   Richard Guo <rguo@postgresql.org>
Date:     Wed Mar 26 08:46:51 2025 +0000
First released in: 18.0, 16.9, 17.5

    Fix integer-overflow problem in scram_SaltedPassword()
    
    Setting the iteration count for SCRAM secret generation to INT_MAX
    will cause an infinite loop in scram_SaltedPassword() due to integer
    overflow, as the loop uses the "i <= iterations" comparison.  To fix,
    use "i < iterations" instead.
    
    Back-patch to v16 where the user-settable GUC scram_iterations has
    been added.
    
    Author: Kevin K Biju <kevinkbiju@gmail.com>
    Reviewed-by: Richard Guo <guofenglinux@gmail.com>
    Reviewed-by: Michael Paquier <michael@paquier.xyz>
    Discussion: https://postgr.es/m/CAM45KeEMm8hnxdTOxA98qhfZ9CzGDdgy3mxgJmy0c+2WwjA6Zg@mail.gmail.com


 src/common/scram-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/common/scram-common.c b/src/common/scram-common.c
index 51cc12e8c3e..c36ed7124c2 100644
--- a/src/common/scram-common.c
+++ b/src/common/scram-common.c
@@ -74,7 +74,7 @@ scram_SaltedPassword(const char *password,
 	memcpy(result, Ui_prev, key_length);
 
 	/* Subsequent iterations */
-	for (i = 2; i <= iterations; i++)
+	for (i = 1; i < iterations; i++)
 	{
 #ifndef FRONTEND
 		/*


[parent: f186f90e55b7]