postgres.git / summary / log / commit / refs

commit    377790fbd707b41bdf2264fe6c217e903e241f7c
Author:   Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:     Mon May 05 13:21:46 2014 +0000

    Pass sensible value to memset() when randomizing reorderbuffer's tuple slab.
    
    This is entirely harmless, but still wrong. Noticed by coverity.
    
    Andres Freund


 src/backend/replication/logical/reorderbuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index e0e9e5c5b89..a2b2adb1732 100644
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -456,7 +456,7 @@ ReorderBufferGetTupleBuf(ReorderBuffer *rb)
 		tuple = slist_container(ReorderBufferTupleBuf, node,
 								slist_pop_head_node(&rb->cached_tuplebufs));
 #ifdef USE_ASSERT_CHECKING
-		memset(tuple, 0xdeadbeef, sizeof(ReorderBufferTupleBuf));
+		memset(tuple, 0xa9, sizeof(ReorderBufferTupleBuf));
 #endif
 	}
 	else


[parent: 329de9fa983d]