pgpool2.git / summary / log / commit / refs

commit    398cf4c7a8a8dc79231a3ac2149b123bc8f0f619
Author:   Tatsuo Ishii <ishii@postgresql.org>
Date:     Fri Aug 08 13:15:41 2014 +0000

    Remove meaningless minus check because of unsigned int variable.
    
    Coverity issue #1111419, #1111420, #1111422.


 src/query_cache/pool_memqcache.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/query_cache/pool_memqcache.c b/src/query_cache/pool_memqcache.c
index b39ad9bc3..568447d9b 100644
--- a/src/query_cache/pool_memqcache.c
+++ b/src/query_cache/pool_memqcache.c
@@ -1941,7 +1941,7 @@ static void pool_update_fsmm(POOL_CACHE_BLOCKID blockid, size_t free_space)
 		return;
 	}
 
-	if (free_space < 0 || free_space > POOL_MAX_FREE_SPACE)
+	if (free_space > POOL_MAX_FREE_SPACE)
 	{
 		pool_error("pool_set_free_space: invalid free space %zd", free_space);
 		return;
@@ -2339,7 +2339,7 @@ static int pool_delete_item_shmem_cache(POOL_CACHEID *cacheid)
 		return -1;
 	}
 
-	if (cacheid->itemid < 0 || cacheid->itemid >= bh->num_items)
+	if (cacheid->itemid >= bh->num_items)
 	{
 		/*
 		 * This could happen if the block is reused.  Since contents
@@ -2424,7 +2424,7 @@ static POOL_CACHE_ITEM_HEADER *pool_cache_item_header(POOL_CACHEID *cacheid)
 	}
 
 	bh = (POOL_CACHE_BLOCK_HEADER *)block_address(cacheid->blockid);
-	if (cacheid->itemid < 0 || cacheid->itemid >= bh->num_items)
+	if (cacheid->itemid >= bh->num_items)
 	{
 		pool_error("pool_cache_item_header: invalid item id %d", cacheid->itemid);
 		return NULL;


[parent: 3daccc9c47ca]