postgres.git / summary / log / commit / refs

commit    399f7ce3daa692a5bebbba50bf9cb773f6469613
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Wed Sep 03 01:20:33 2025 +0000
First released in: 17.7, 18.0

    Update outdated references to the SLRU ControlLock
    
    SLRU bank locks are referred as "bank locks" or "SLRU bank locks" in the
    code comments.  The comments updated in this commit use the latter term.
    
    Oversight in 53c2a97a9266, that has replaced the single ControlLock by
    the bank control locks.
    
    Author: Julien Rouhaud <julien.rouhaud@free.fr>
    Discussion: https://postgr.es/m/aLUT2UO8RjJOzZNq@jrouhaud
    Backpatch-through: 17


 src/backend/access/transam/slru.c | 8 ++++----
 src/include/access/slru.h         | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c
index fe56286d9a9..bcc6adb4d29 100644
--- a/src/backend/access/transam/slru.c
+++ b/src/backend/access/transam/slru.c
@@ -400,10 +400,10 @@ SimpleLruZeroPage(SlruCtl ctl, int64 pageno)
 	/*
 	 * Assume this page is now the latest active page.
 	 *
-	 * Note that because both this routine and SlruSelectLRUPage run with
-	 * ControlLock held, it is not possible for this to be zeroing a page that
-	 * SlruSelectLRUPage is going to evict simultaneously.  Therefore, there's
-	 * no memory barrier here.
+	 * Note that because both this routine and SlruSelectLRUPage run with a
+	 * SLRU bank lock held, it is not possible for this to be zeroing a page
+	 * that SlruSelectLRUPage is going to evict simultaneously.  Therefore,
+	 * there's no memory barrier here.
 	 */
 	pg_atomic_write_u64(&shared->latest_page_number, pageno);
 
diff --git a/src/include/access/slru.h b/src/include/access/slru.h
index e142800aab2..d5ca3447208 100644
--- a/src/include/access/slru.h
+++ b/src/include/access/slru.h
@@ -55,7 +55,7 @@ typedef enum
 /*
  * Shared-memory state
  *
- * ControlLock is used to protect access to the other fields, except
+ * SLRU bank locks are used to protect access to the other fields, except
  * latest_page_number, which uses atomics; see comment in slru.c.
  */
 typedef struct SlruSharedData


[parent: 620062230131]