postgres.git / summary / log / commit / refs

commit    39e22b3adaa7738da4d7ff536a2ab5e303e7c890
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Fri Oct 17 04:01:17 2025 +0000
First released in: 18.1

    pg_createsubscriber: Fix matching check in TAP test
    
    040_pg_createsubscriber has been calling safe_psql(), that returns the
    result of a SQL query, with ok() without checking the result generated
    (in this case 't', for a number of publications).
    
    The outcome of the tests is currently not impacted by this change.
    However, it could be possible that the test fails to detect future
    issues if the query results become different.
    
    The test is rewritten so as the number of publications is checked.  This
    is not the fix suggested originally by the author, but this is more
    reliable in the long run.
    
    Oversight in e5aeed4b8020.
    
    Author: Sadhuprasad Patro <b.sadhu@gmail.com>
    Discussion: https://postgr.es/m/CAFF0-CHhwNx_Cv2uy7tKjODUbeOgPrJpW4Rpf1jqB16_1bU2sg@mail.gmail.com
    Backpatch-through: 18


 src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
index 229fef5b3b5..7018dd6f74d 100644
--- a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
+++ b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
@@ -341,8 +341,8 @@ $node_p->safe_psql(
 
 $node_p->wait_for_replay_catchup($node_s);
 
-ok($node_s->safe_psql($db1, "SELECT COUNT(*) = 2 FROM pg_publication"),
-	'two pre-existing publications on subscriber');
+is($node_s->safe_psql($db1, "SELECT COUNT(*) FROM pg_publication"),
+	'2', 'two pre-existing publications on subscriber');
 
 $node_s->stop;
 


[parent: 6aa04a60cbf5]