postgres.git / summary / log / commit / refs

commit    3dd42ee97b812c0711b4d18e9cab069065367dca
Author:   Nathan Bossart <nathan@postgresql.org>
Date:     Wed Apr 29 17:25:09 2026 +0000
First released in: 19.0, 14.23, 15.18, 16.14, 17.10, 18.4

    Suppress "has no symbols" linker warnings on macOS.
    
    After a recent macOS update, building Postgres produces warnings
    that look like this:
    
        ranlib: warning: 'libpgport_shlib.a(pg_cpu_x86.c.o)' has no symbols
        ranlib: warning: 'libpgport_shlib.a(pg_popcount_x86.c.o)' has no symbols
    
    To fix, add a dummy symbol to files that may otherwise have none.
    Per project policy, this is a candidate for back-patching into
    out-of-support branches: it suppresses annoying compiler warnings
    but changes no behavior.
    
    Reported-by: Zhang Mingli <zmlpostgres@gmail.com>
    Reviewed-by: John Naylor <johncnaylorls@gmail.com>
    Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
    Discussion: https://postgr.es/m/229aaaf3-f529-44ed-8e50-00cb6909af21%40Spark
    Backpatch-through: 13


src/port/pg_cpu_x86.c | 7 ++++++- src/port/pg_popcount_aarch64.c | 8 +++++++- src/port/pg_popcount_x86.c | 8 +++++++- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/port/pg_cpu_x86.c b/src/port/pg_cpu_x86.c index 150b4a1d574..f22167da9af 100644 --- a/src/port/pg_cpu_x86.c +++ b/src/port/pg_cpu_x86.c @@ -263,5 +263,10 @@ x86_hypervisor_tsc_frequency_khz(void) return 0; } +#else /* defined(USE_SSE2) || defined(__i386__) */ -#endif /* defined(USE_SSE2) || defined(__i386__) */ +/* prevent linker complaints about empty module */ +extern int pg_cpu_x86_dummy_variable; +int pg_cpu_x86_dummy_variable = 0; + +#endif /* ! (USE_SSE2 || __i386__) */ diff --git a/src/port/pg_popcount_aarch64.c b/src/port/pg_popcount_aarch64.c index 3969a42523c..fc249bf8766 100644 --- a/src/port/pg_popcount_aarch64.c +++ b/src/port/pg_popcount_aarch64.c @@ -463,4 +463,10 @@ pg_popcount_masked_neon(const char *buf, int bytes, uint8 mask) return popcnt; } -#endif /* USE_NEON */ +#else /* USE_NEON */ + +/* prevent linker complaints about empty module */ +extern int pg_popcount_aarch64_dummy_variable; +int pg_popcount_aarch64_dummy_variable = 0; + +#endif /* ! USE_NEON */ diff --git a/src/port/pg_popcount_x86.c b/src/port/pg_popcount_x86.c index 91579e6b569..6df76c77c41 100644 --- a/src/port/pg_popcount_x86.c +++ b/src/port/pg_popcount_x86.c @@ -301,4 +301,10 @@ pg_popcount_masked_sse42(const char *buf, int bytes, uint8 mask) return popcnt; } -#endif /* HAVE_X86_64_POPCNTQ */ +#else /* HAVE_X86_64_POPCNTQ */ + +/* prevent linker complaints about empty module */ +extern int pg_popcount_x86_dummy_variable; +int pg_popcount_x86_dummy_variable = 0; + +#endif /* ! HAVE_X86_64_POPCNTQ */ [parent: a424e31b16ba]