postgres.git / summary / log / commit / refs

commit    3e6741e8dd5b585e85b5d9371453ff80aa1f0c04
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Thu Aug 14 07:22:00 2025 +0000
First released in: 16.11, 17.7, 18.0

    Fix compilation warning with SerializeClientConnectionInfo()
    
    This function uses an argument named "maxsize" that is only used in
    assertions, being set once outside the assertion area.  Recent gcc
    versions with -Wunused-but-set-parameter complain about a warning when
    building without assertions enabled, because of that.
    
    In order to fix this issue, PG_USED_FOR_ASSERTS_ONLY is added to the
    function argument of SerializeClientConnectionInfo(), which is the first
    time we are doing so in the tree.  The CI is fine with the change, but
    let's see what the buildfarm has to say on the matter.
    
    Reviewed-by: Andres Freund <andres@anarazel.de>
    Reviewed-by: Jacob Champion <jchampion@postgresql.org>
    Discussion: https://postgr.es/m/pevajesswhxafjkivoq3yvwxga77tbncghlf3gq5fvchsvfuda@6uivg25sb3nx
    Backpatch-through: 16


 src/backend/utils/init/miscinit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c
index 8ac8ecc0dbb..0d06f0bdc70 100644
--- a/src/backend/utils/init/miscinit.c
+++ b/src/backend/utils/init/miscinit.c
@@ -1094,7 +1094,8 @@ EstimateClientConnectionInfoSpace(void)
  * Serialize MyClientConnectionInfo for use by parallel workers.
  */
 void
-SerializeClientConnectionInfo(Size maxsize, char *start_address)
+SerializeClientConnectionInfo(Size maxsize PG_USED_FOR_ASSERTS_ONLY,
+							  char *start_address)
 {
 	SerializedClientConnectionInfo serialized = {0};
 


[parent: 3e6059cc70c0]