postgres.git / summary / log / commit / refs

commit    412d29fd21665d0c4e473efbc9636bd0c16d12a8
Author:   Noah Misch <noah@leadboat.com>
Date:     Sat Aug 23 23:46:20 2025 +0000

    Rewrite previous commit's test for TestUpgradeXversion compatibility.
    
    v17 introduced the MAINTAIN ON TABLES privilege.  That changed the
    applicable "baseacls" reaching buildACLCommands().  That yielded
    spurious TestUpgradeXversion diffs.  Change to use a TYPES privilege.
    Types have the same one privilege in all supported versions, so they
    avoid the problem.  Per buildfarm.  Back-patch to v13, like that commit.
    
    Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com
    Backpatch-through: 13


 src/test/regress/expected/privileges.out | 4 ++--
 src/test/regress/sql/privileges.sql      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/test/regress/expected/privileges.out b/src/test/regress/expected/privileges.out
index a8bdd930fb0..90b33660c5e 100644
--- a/src/test/regress/expected/privileges.out
+++ b/src/test/regress/expected/privileges.out
@@ -2827,9 +2827,9 @@ DROP USER regress_priv_user8; -- does not exist
 ERROR:  role "regress_priv_user8" does not exist
 -- leave some default ACLs for pg_upgrade's dump-restore test input.
 ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend
-	REVOKE INSERT ON TABLES FROM pg_signal_backend;
+	REVOKE USAGE ON TYPES FROM pg_signal_backend;
 ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings
-	REVOKE INSERT ON TABLES FROM pg_read_all_settings;
+	REVOKE USAGE ON TYPES FROM pg_read_all_settings;
 -- permissions with LOCK TABLE
 CREATE USER regress_locktable_user;
 CREATE TABLE lock_table (a int);
diff --git a/src/test/regress/sql/privileges.sql b/src/test/regress/sql/privileges.sql
index 5648752864f..381ba9d8ac7 100644
--- a/src/test/regress/sql/privileges.sql
+++ b/src/test/regress/sql/privileges.sql
@@ -1766,9 +1766,9 @@ DROP USER regress_priv_user8; -- does not exist
 
 -- leave some default ACLs for pg_upgrade's dump-restore test input.
 ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend
-	REVOKE INSERT ON TABLES FROM pg_signal_backend;
+	REVOKE USAGE ON TYPES FROM pg_signal_backend;
 ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings
-	REVOKE INSERT ON TABLES FROM pg_read_all_settings;
+	REVOKE USAGE ON TYPES FROM pg_read_all_settings;
 
 
 -- permissions with LOCK TABLE


[parent: e68fa9a830f0]