pgpool2.git / summary / log / commit / refs

commit    41a01c41b7733043e9660b4d348ca558c48bf66a
Author:   Tatsuo Ishii <ishii@sraoss.co.jp>
Date:     Tue Jul 09 22:38:21 2019 +0000

    Fix logically dead code pointed out by Coverity.
    
    Whether pwd is NULL or not was already checked, and there's no point
    to check it again.


 src/auth/pool_auth.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/auth/pool_auth.c b/src/auth/pool_auth.c
index 5c790a9b4..2cc50fe24 100644
--- a/src/auth/pool_auth.c
+++ b/src/auth/pool_auth.c
@@ -3,7 +3,7 @@
  * pgpool: a language independent connection pool server for PostgreSQL
  * written by Tatsuo Ishii
  *
- * Copyright (c) 2003-2018	PgPool Global Development Group
+ * Copyright (c) 2003-2019	PgPool Global Development Group
  *
  * Permission to use, copy, modify, and distribute this software and
  * its documentation for any purpose and without fee is hereby
@@ -1051,7 +1051,7 @@ do_clear_text_password(POOL_CONNECTION * backend, POOL_CONNECTION * frontend, in
 		return 0;
 	}
 
-	size = pwd ? strlen(pwd) : 0;
+	size = strlen(pwd);
 
 	/* connection reusing? */
 	if (reauth)


[parent: c20312d283ce]