postgres.git / summary / log / commit / refs

commit    420c8dc7ec67ca050d53c559d1e852c59e7053ef
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Tue Aug 29 23:03:54 2023 +0000
First released in: 17.0, 13.13, 14.10, 15.5, 16.0

    Avoid possible overflow with ltsGetFreeBlock() in logtape.c
    
    nFreeBlocks, defined as a long, stores the number of free blocks in a
    logical tape.  ltsGetFreeBlock() has been using an int to store the
    value of nFreeBlocks, which could lead to overflows on platforms where
    long and int are not the same size (in short everything except Windows
    where long is 4 bytes).
    
    The problematic intermediate variable is switched to be a long instead
    of an int.
    
    Issue introduced by c02fdc9223015, so backpatch down to 13.
    
    Author: Ranier vilela
    Reviewed-by: Peter Geoghegan, David Rowley
    Discussion: https://postgr.es/m/CAEudQApLDWCBR_xmwNjGBrDo+f+S4E87x3s7-+hoaKqYdtC4JQ@mail.gmail.com
    Backpatch-through: 13


 src/backend/utils/sort/logtape.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/sort/logtape.c b/src/backend/utils/sort/logtape.c
index c6fcb87d744..720f9dfe2b7 100644
--- a/src/backend/utils/sort/logtape.c
+++ b/src/backend/utils/sort/logtape.c
@@ -389,7 +389,7 @@ ltsGetFreeBlock(LogicalTapeSet *lts)
 {
 	long	   *heap = lts->freeBlocks;
 	long		blocknum;
-	int			heapsize;
+	long		heapsize;
 	unsigned long pos;
 
 	/* freelist empty; allocate a new block */


[parent: a01e479e8483]