postgres.git / summary / log / commit / refs

commit    42a9e88bf6a809e6023c9d50f58cc6b9446f229d
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Mon Feb 07 05:19:52 2022 +0000
First released in: 15.0

    Add (void) cast in front of rmtree() call at the end of pg_upgrade
    
    Most calls of rmtree() report an error, and the code coming from 38bfae3
    has introduced one caller where this is not done.  The previous behavior
    was to not fail hard if any log file generated is not properly unlinked
    when cleaning up the contents generated once the upgrade has completed,
    so add a cast to (void) to indicate the intention behind this new code.
    
    Per gripe from Coverity.


 src/bin/pg_upgrade/pg_upgrade.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pg_upgrade/pg_upgrade.c b/src/bin/pg_upgrade/pg_upgrade.c
index 48a54170a72..77beb116398 100644
--- a/src/bin/pg_upgrade/pg_upgrade.c
+++ b/src/bin/pg_upgrade/pg_upgrade.c
@@ -754,5 +754,5 @@ cleanup(void)
 
 	/* Remove dump and log files? */
 	if (!log_opts.retain)
-		rmtree(log_opts.basedir, true);
+		(void) rmtree(log_opts.basedir, true);
 }


[parent: 38bfae365266]