postgrespro.git / summary / log / commit / refs

commit    42f74f49367bee1d3da28c4b383faec29364f320
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Wed Dec 25 19:45:57 2019 +0000

    Remove equalPartitionDescs().
    
    This is dead code in the wake of the previous commit.
    We can always add it back if we need it again someday.
    
    Discussion: https://postgr.es/m/CA+HiwqFUzjfj9HEsJtYWcr1SgQ_=iCAvQ=O2Sx6aQxoDu4OiHw@mail.gmail.com


 src/backend/partitioning/partdesc.c | 54 -------------------------------------
 src/include/partitioning/partdesc.h |  3 ---
 2 files changed, 57 deletions(-)

diff --git a/src/backend/partitioning/partdesc.c b/src/backend/partitioning/partdesc.c
index a6e397940b..694ed923e0 100644
--- a/src/backend/partitioning/partdesc.c
+++ b/src/backend/partitioning/partdesc.c
@@ -351,60 +351,6 @@ DestroyPartitionDirectory(PartitionDirectory pdir)
 		RelationDecrementReferenceCount(pde->rel);
 }
 
-/*
- * equalPartitionDescs
- *		Compare two partition descriptors for logical equality
- */
-bool
-equalPartitionDescs(PartitionKey key, PartitionDesc partdesc1,
-					PartitionDesc partdesc2)
-{
-	int			i;
-
-	if (partdesc1 != NULL)
-	{
-		if (partdesc2 == NULL)
-			return false;
-		if (partdesc1->nparts != partdesc2->nparts)
-			return false;
-
-		Assert(key != NULL || partdesc1->nparts == 0);
-
-		/*
-		 * Same oids? If the partitioning structure did not change, that is,
-		 * no partitions were added or removed to the relation, the oids array
-		 * should still match element-by-element.
-		 */
-		for (i = 0; i < partdesc1->nparts; i++)
-		{
-			if (partdesc1->oids[i] != partdesc2->oids[i])
-				return false;
-		}
-
-		/*
-		 * Now compare partition bound collections.  The logic to iterate over
-		 * the collections is private to partition.c.
-		 */
-		if (partdesc1->boundinfo != NULL)
-		{
-			if (partdesc2->boundinfo == NULL)
-				return false;
-
-			if (!partition_bounds_equal(key->partnatts, key->parttyplen,
-										key->parttypbyval,
-										partdesc1->boundinfo,
-										partdesc2->boundinfo))
-				return false;
-		}
-		else if (partdesc2->boundinfo != NULL)
-			return false;
-	}
-	else if (partdesc2 != NULL)
-		return false;
-
-	return true;
-}
-
 /*
  * get_default_oid_from_partdesc
  *
diff --git a/src/include/partitioning/partdesc.h b/src/include/partitioning/partdesc.h
index 825bdd76ab..23be527a5a 100644
--- a/src/include/partitioning/partdesc.h
+++ b/src/include/partitioning/partdesc.h
@@ -38,7 +38,4 @@ extern void DestroyPartitionDirectory(PartitionDirectory pdir);
 
 extern Oid	get_default_oid_from_partdesc(PartitionDesc partdesc);
 
-extern bool equalPartitionDescs(PartitionKey key, PartitionDesc partdesc1,
-								PartitionDesc partdesc2);
-
 #endif							/* PARTCACHE_H */


[parent: 5b9312378e2f]